Bug 18591: Allow any number of comments on ILLs
authorMagnus Enger <magnus@libriotech.no>
Mon, 20 Nov 2017 14:14:30 +0000 (14:14 +0000)
committerNick Clemens <nick@bywatersolutions.com>
Sat, 27 Oct 2018 13:15:58 +0000 (13:15 +0000)
commit2460eb0597b699eb8c4afc19c727091fca1f4200
tree451ce04c4c2f576b385ad2331d743b7b829538a8
parentcf5835fc5286c7e087da2eeec06cf0417a2502d3
Bug 18591: Allow any number of comments on ILLs

This patch makes it possible to add arbitrary comments to ILL
requests. Comments are read only and displayed in chronological
order. Comments can be added by librarians, but also added automatically
based on comments in the different protocols, so that comments from the
lending library can also be added.

To test:
- Enable the ILL module ("ILLModule" syspref + config in koha-conf.xml)
- Install the Dummy backend from here:
  https://github.com/PTFS-Europe/Dummy
- Create a Dummy ILL request
- Add comments to the request, checking that the name and borrowernumber
  of the person that added the comment is displayed ok
- Check that the displayed date and time the comment was submitted follows
  the "dateformat" syspref
- On the "List requests" page, check that the correct number of comments
  is displayed in the "Comments" column
- Check that the tests pass:
  prove t/db_dependent/Illcomments.t

Signed-off-by: andrew.isherwood@ptfs-europe.com

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Koha/Illcomment.pm [new file with mode: 0644]
Koha/Illcomments.pm [new file with mode: 0644]
Koha/Illrequest.pm
ill/ill-requests.pl
koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
t/db_dependent/Illcomments.t [new file with mode: 0644]