Bug 22284: (QA follow-up) Make pickup locations be Koha::Library objects
authorTomas Cohen Arazi <tomascohen@theke.io>
Sat, 21 Dec 2019 03:14:10 +0000 (00:14 -0300)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Fri, 3 Jan 2020 12:58:06 +0000 (12:58 +0000)
commit23bddb729dc2655958b6860c8f2d9f9872754ccf
tree909fb233ec972028903458fdc446fce36824b883
parent1072e364bd93419ead69c85222eb21d76a6b9060
Bug 22284: (QA follow-up) Make pickup locations be Koha::Library objects

This patch makes the following methods return array references of
Koha::Library objects instead or unblessed objects;

- Koha::Item->pickup_locations
- Koha::Biblio->pickup_locations
- Koha::Libraries->pickup_locations

Bonus:

- The template plugin is adjusted to unbless things to keep behavior
- Tests are moved to the right .t file.
- Tests for the new behavior are added.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Koha/Biblio.pm
Koha/Item.pm
Koha/Libraries.pm
Koha/Template/Plugin/Branches.pm
reserve/request.pl
t/db_dependent/Koha/Biblio.t
t/db_dependent/Koha/Biblios.t
t/db_dependent/Koha/Item.t
t/db_dependent/Koha/Items.t
t/db_dependent/Koha/Libraries.t