Bug 21417: EDI ordering fails when basket and EAN libraries do not match
authorKyle M Hall <kyle@bywatersolutiosn.com>
Thu, 27 Sep 2018 10:51:27 +0000 (06:51 -0400)
committerNick Clemens <nick@bywatersolutions.com>
Tue, 9 Oct 2018 11:54:08 +0000 (11:54 +0000)
commit18674cfde322c52fafb3114b397bb1ebe7941b97
treef4478dc30afc6bef8c9367b614e8f926bc2ff266
parent6cee98c04fce2129de21c65c9e0c407a508df9bd
Bug 21417: EDI ordering fails when basket and EAN libraries do not match

When clicking Create EDIFACT Order on /acqui/basket.pl, an EDIFACT message will not be generated if aqbasket.branch does not match edifact_ean.branchcode. This failure does not generate any sort of error message, it just fails to produce a message.

We should allow ean's to not require a branch to be set, then if we don't find a branch specific each, we can look for the default version of the ean.

Test Plan:
1) Apply this patch set
2) Run updatedatabase
3) Verify you can create a Library EAN without setting a branchcode for it
4) Verify you can use this EAN to send an EDI order where the basket has a branchcode set

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Koha/EDI.pm
admin/edi_ean_accounts.pl
installer/data/mysql/atomicupdate/bug_21417.perl [new file with mode: 0644]
installer/data/mysql/kohastructure.sql
koha-tmpl/intranet-tmpl/prog/en/modules/admin/edi_ean_accounts.tt