Bug 21176: Fix due date calculation when high holds and TimeFormat is 12hr
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 13 Aug 2018 16:23:00 +0000 (13:23 -0300)
committerNick Clemens <nick@bywatersolutions.com>
Mon, 1 Oct 2018 23:53:05 +0000 (23:53 +0000)
commit11885e75c04fa53cd88daae1ec0dc4a2a8ecd1f7
treed4ef1f6590274e3cc18e4efae975eebecea6024d
parentfca98de0e8663c4e7049e55ac2cc2600c9b659a5
Bug 21176: Fix due date calculation when high holds and TimeFormat is 12hr

What we were doing was wrong and is still wrong. The output_pref should not be done
in modules or script, only template side.
Much more work would be needed to clean the situation. This patch provides less changes
as possible to, hopefully, not introduce side-effects.

To recreate:
1 - Enable decreaseLoanHighHolds, set to 1 day and more than 0 holds
2 - Set TimeFormat to 12 hour
3 - Find or create a record with two items
4 - Place a hold on one of them
5 - Checkout the other to a different patron
6 - Note the warning message display correct time
7 - Confirm the checkout
8 - Note the item is due at 11:59AM

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
C4/Circulation.pm
koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt