Bug 25048: Make successful resource deletion return 204
authorTomas Cohen Arazi <tomascohen@theke.io>
Thu, 2 Apr 2020 21:40:49 +0000 (18:40 -0300)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Wed, 29 Apr 2020 15:24:43 +0000 (16:24 +0100)
commit0bb0b6c7b42428320603896233f45ea5f4af670c
treecee64ae8b7cb509d470472c996a6e5a146775f93
parentb33d69684f24249fd14c668fd2164cea380697db
Bug 25048: Make successful resource deletion return 204

This patch adapts the spec and the controllers so existing routes return
204 and an empty response body when a successful deletion happens.

Right now we have a coding guideline but haven't adapted the existing
routes.

To test:
1. Apply the regression tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/*.t
=> FAIL: Some tests fail
3. Apply this patch
4. Repeat 2.
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Koha/REST/V1/Acquisitions/Vendors.pm
Koha/REST/V1/Cities.pm
Koha/REST/V1/Holds.pm
Koha/REST/V1/Patrons.pm
api/v1/swagger/paths/acquisitions_orders.json
api/v1/swagger/paths/acquisitions_vendors.json
api/v1/swagger/paths/cities.json
api/v1/swagger/paths/holds.json
api/v1/swagger/paths/patrons.json