Bug 7317: Handle backend absense more gracefuly
authorTomas Cohen Arazi <tomascohen@theke.io>
Tue, 31 Oct 2017 19:28:53 +0000 (16:28 -0300)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 9 Nov 2017 14:42:14 +0000 (11:42 -0300)
commit06f9e5fe3aa95be62e40a9a7a85cb0d31b3278d6
treed1c4d056f295e9eab5190c818e1d4357d767c33f
parent66727e6c688f5cc61243c8e789ff82bab5b98fae
Bug 7317: Handle backend absense more gracefuly

5/ This patch makes Koha::Illrequest->load_backend raise an exception
if the passed backend is invalid. This way we will catch more errors introduced.

The patch also disables the 'New Ill request' when no backends are available. Gets
rid of a related warnings.

Both OPAC and Intranet now display a warning message when no backends
are available.

Tests are added for the load_backend changes.

4/ This patch fixes the path for the checkboxes jquery plugin, and removes the include
for tablesorter, as this implementation uses Datatables. This is obviously code for older
Koha, ported to master.

TODO: There's something wrong on the styling. My idea is to get rid
of the custom column visualization tool, and have it display as regular
DataTables. We can then introduce the use of colvis on a separate bug
report.

Note: POD coverage for the exceptions file is wrongly tested. It is a false positive.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
12 files changed:
Koha/Exceptions/Ill.pm [new file with mode: 0644]
Koha/Illrequest.pm
Koha/Illrequest/Config.pm
Koha/Illrequestattribute.pm
about.pl
ill/ill-requests.pl
koha-tmpl/intranet-tmpl/prog/en/includes/ill-toolbar.inc
koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt
opac/opac-illrequests.pl
t/db_dependent/Illrequests.t