Bug 23686: Check onsite checkout when the last checkout was an onsite one
authorNicolas Legrand <nicolas.legrand@bulac.fr>
Fri, 27 Sep 2019 08:14:35 +0000 (10:14 +0200)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Thu, 3 Oct 2019 09:47:31 +0000 (10:47 +0100)
commit059cc81891082910f14cf9586288a8d302de5f7f
treeaa6738a16321a47eb64c308269d44fcf5815d4f4
parentdca51f46aa127fcce439561656da5606dc72e4f8
Bug 23686: Check onsite checkout when the last checkout was an onsite one

Prevent from checking again and again the onsite checkout box when
doing onsite checkouts in batches. If preceding checkout was an onsite
one, the box will be checked.

Test plan:

1. enable  OnSiteCheckouts
2. make your circulation rules able to checkout onsite
3. onsite checkout a document
4. you should return to the checkout page, the box isn't checked
5. apply patch
6. updatedatabase.pl
7. redo steps 3, it should again print a checkout page with an
   unchecked onsite checkout box
8. enable  OnSiteCheckoutAutoCheck system preference
9. redo step 3
10. when returning to the checkout page, the onsite checkout box
    should be already checked

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
circ/circulation.pl
installer/data/mysql/atomicupdate/bug_23686_autocheck_onsitecheckout.perl [new file with mode: 0644]
installer/data/mysql/sysprefs.sql
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt