Bug 26265: (QA follow-up) Remove g option from regex, add few dirs

[koha-equinox.git] / fix-perl-path.PL

diff --git a/fix-perl-path.PL b/fix-perl-path.PL
index 7e23b0b..2adfa35 100644 (file)
--- a/fix-perl-path.PL
+++ b/fix-perl-path.PL
@@ -1,18 +1,18 @@
 #!/usr/bin/perl
 # This file is part of Koha.
 #
-# Koha is free software; you can redistribute it and/or modify it under the
-# terms of the GNU General Public License as published by the Free Software
-# Foundation; either version 2 of the License, or (at your option) any later
-# version.
+# Koha is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
 #
-# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
-# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
-# A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
+# Koha is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
 #
-# You should have received a copy of the GNU General Public License along with
-# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
-# Suite 330, Boston, MA  02111-1307 USA
+# You should have received a copy of the GNU General Public License
+# along with Koha; if not, see <http://www.gnu.org/licenses>.
 #
 
 use strict;
@@ -20,7 +20,7 @@ use ExtUtils::MakeMaker::Config;
 use Tie::File;
 
 my $basedir = (shift);
-my $DEBUG = 1;
+my $DEBUG = exists $ENV{'DEBUG'} ? $ENV{'DEBUG'} : 0;
 
 $DEBUG = 1 if $basedir eq 'test';
 
@@ -71,26 +71,37 @@ sub fixshebang{
             my @filearray;
                        my $pathfile =$dir . '/' . $file;
                        warn "Found a perl script named $pathfile\n" if $DEBUG;
-            tie @filearray, 'Tie::File', $pathfile or die $!;
+
+            # At this point, file is in 'blib' and by default
+            # has mode a-w.  Therefore, must change permission
+            # to make it writable.  Note that stat and chmod
+            # (the Perl functions) should work on Win32
+            my $old_perm;
+            $old_perm = (stat $pathfile)[2] & oct(7777);
+            my $new_perm = $old_perm | oct(200);
+            chmod $new_perm, $pathfile;
+
+            # tie the file -- note that we're explicitly setting the line (record)
+            # separator to hex 0A (the Unix newline) because that's what
+            # the files copied to blib are using, regardless of whether the install
+            # is under a Unix variant or Windows.
+            tie @filearray, 'Tie::File', $pathfile, recsep => "\x0a" or die $!;
+
             warn "First line of $file is $filearray[0]\n\n" if $DEBUG;
                        if ( ( $filearray[0] =~ /#!.*perl/ ) && ( $filearray[0] !~ /$shebang|"$shebang -w"/ ) ) {
                                warn "\n\tRe-writing shebang line for $pathfile\n" if $DEBUG;
                 warn "\tOriginal shebang line: $filearray[0]\n" if $DEBUG;
                 $filearray[0] =~ /-w$/ ? $filearray[0] = "$shebang -w" : $filearray[0] = $shebang;
                 warn "\tNew shebang line is: $filearray[0]\n\n" if $DEBUG;
-                untie @filearray;
-                next;
                        }
             elsif ( $filearray[0] =~ /$shebang|"$shebang -w"/ ) {
                 warn "\n\tShebang line is correct.\n\n" if $DEBUG;
-                untie @filearray;
-                next;
             }
                        else {
                 warn "\n\tNo shebang line found in $pathfile\n\n" if $DEBUG;
-                untie @filearray;
-                               next;
                        }
+            untie @filearray;
+            chmod $old_perm, $pathfile;
                }
                # handle directories
                elsif ( -d ($dir . '/' . $file) && $file !~ /^\.{1,2}/ ) {