Bug 26265: (QA follow-up) Remove g option from regex, add few dirs

[koha-equinox.git] / about.pl

diff --git a/about.pl b/about.pl
index fa52ce4..029bd94 100755 (executable)
--- a/about.pl
+++ b/about.pl
@@ -25,6 +25,7 @@ use Modern::Perl;
 use CGI qw ( -utf8 );
 use DateTime::TimeZone;
 use File::Spec;
+use File::Slurp;
 use List::MoreUtils qw/ any /;
 use LWP::Simple;
 use Module::Load::Conditional qw(can_load);
@@ -42,12 +43,15 @@ use C4::Installer::PerlModules;
 use Koha;
 use Koha::DateUtils qw(dt_from_string output_pref);
 use Koha::Acquisition::Currencies;
+use Koha::BiblioFrameworks;
 use Koha::Patron::Categories;
 use Koha::Patrons;
 use Koha::Caches;
 use Koha::Config::SysPrefs;
 use Koha::Illrequest::Config;
 use Koha::SearchEngine::Elasticsearch;
+use Koha::Logger;
+use Koha::Filter::MARC::ViewPolicy;
 
 use C4::Members::Statistics;
 
@@ -93,6 +97,24 @@ my $time_zone = {
     environment_invalid    => $env_invalid
 };
 
+{ # Logger checks
+    my $log4perl_config = C4::Context->config("log4perl_conf");
+    my @log4perl_errors;
+    if ( ! $log4perl_config ) {
+        push @log4perl_errors, 'missing_config_entry'
+    }
+    else {
+        my @lines = read_file($log4perl_config) or push @log4perl_errors, 'cannot_read_config_file';
+        for my $line ( @lines ) {
+            next unless $line =~ m|log4perl.appender.\w+.filename=(.*)|;
+            push @log4perl_errors, 'logfile_not_writable' unless -w $1;
+        }
+    }
+    eval {Koha::Logger->get};
+    push @log4perl_errors, 'cannot_init_module' and warn $@ if $@;
+    $template->param( log4perl_errors => @log4perl_errors );
+}
+
 $template->param(
     time_zone              => $time_zone,
     current_date_and_time  => output_pref({ dt => dt_from_string(), dateformat => 'iso' })
@@ -197,7 +219,10 @@ if (    C4::Context->config('zebra_auth_index_mode')
     push @xml_config_warnings, { error => 'zebra_auth_index_mode_is_grs1' };
 }
 
-if ( (C4::Context->config('zebra_auth_index_mode') eq 'dom') && ($context->{'server'}->{'authorityserver'}->{'config'} !~ /zebra-authorities-dom.cfg/) ) {
+if( (   C4::Context->config('zebra_auth_index_mode')
+    and C4::Context->config('zebra_auth_index_mode') eq 'dom' )
+    && ( $context->{'server'}->{'authorityserver'}->{'config'} !~ /zebra-authorities-dom.cfg/ ) )
+{
     push @xml_config_warnings, {
         error => 'zebra_auth_index_mode_mismatch_warn'
     };
@@ -209,6 +234,20 @@ if ( ! defined C4::Context->config('log4perl_conf') ) {
     }
 }
 
+if ( ! defined C4::Context->config('lockdir') ) {
+    push @xml_config_warnings, {
+        error => 'lockdir_entry_missing'
+    }
+}
+else {
+    unless ( -w C4::Context->config('lockdir') ) {
+        push @xml_config_warnings, {
+            error   => 'lockdir_not_writable',
+            lockdir => C4::Context->config('lockdir')
+        }
+    }
+}
+
 if ( ! defined C4::Context->config('upload_path') ) {
     if ( Koha::Config::SysPrefs->find('OPACBaseURL')->value ) {
         # OPACBaseURL seems to be set
@@ -230,35 +269,6 @@ if ( ! C4::Context->config('tmp_path') ) {
     }
 }
 
-# Test QueryParser configuration sanity
-if ( C4::Context->preference( 'UseQueryParser' ) ) {
-    # Get the QueryParser configuration file name
-    my $queryparser_file          = C4::Context->config( 'queryparser_config' );
-    my $queryparser_fallback_file = '/etc/koha/searchengine/queryparser.yaml';
-    # Check QueryParser is functional
-    my $QParser = C4::Context->queryparser();
-    my $queryparser_error = {};
-    if ( ! defined $QParser || ref($QParser) ne 'Koha::QueryParser::Driver::PQF' ) {
-        # Error initializing the QueryParser object
-        # Get the used queryparser.yaml file path to report the user
-        $queryparser_error->{ fallback } = ( defined $queryparser_file ) ? 0 : 1;
-        $queryparser_error->{ file }     = ( defined $queryparser_file )
-                                                ? $queryparser_file
-                                                : $queryparser_fallback_file;
-        # Report error data to the template
-        $template->param( QueryParserError => $queryparser_error );
-    } else {
-        # Check for an absent queryparser_config entry in koha-conf.xml
-        if ( ! defined $queryparser_file ) {
-            # Not an error but a warning for the missing entry in koha-conf-xml
-            push @xml_config_warnings, {
-                    error => 'queryparser_entry_missing',
-                    file  => $queryparser_fallback_file
-            };
-        }
-    }
-}
-
 # Test Zebra facets configuration
 if ( !defined C4::Context->config('use_zebra_facets') ) {
     push @xml_config_warnings, { error => 'use_zebra_facets_entry_missing' };
@@ -510,6 +520,39 @@ $template->param( 'bad_yaml_prefs' => \@bad_yaml_prefs ) if @bad_yaml_prefs;
     }
 }
 
+{
+    # Test 'bcrypt_settings' config for Pseudonymization
+    $template->param( config_bcrypt_settings_no_set => 1 )
+      if C4::Context->preference('Pseudonymization')
+      and not C4::Context->config('bcrypt_settings');
+}
+
+{
+    my @frameworkcodes = Koha::BiblioFrameworks->search->get_column('frameworkcode');
+    my @hidden_biblionumbers;
+    push @frameworkcodes, ""; # it's not in the biblio_frameworks table!
+    for my $frameworkcode ( @frameworkcodes ) {
+        my $shouldhidemarc_opac = Koha::Filter::MARC::ViewPolicy->should_hide_marc(
+            {
+                frameworkcode => $frameworkcode,
+                interface     => "opac"
+            }
+        );
+        push @hidden_biblionumbers, { frameworkcode => $frameworkcode, interface => 'opac' }
+          if $shouldhidemarc_opac->{biblionumber};
+
+        my $shouldhidemarc_intranet = Koha::Filter::MARC::ViewPolicy->should_hide_marc(
+            {
+                frameworkcode => $frameworkcode,
+                interface     => "intranet"
+            }
+        );
+        push @hidden_biblionumbers, { frameworkcode => $frameworkcode, interface => 'intranet' }
+          if $shouldhidemarc_intranet->{biblionumber};
+    }
+    $template->param( warnHiddenBiblionumbers => \@hidden_biblionumbers );
+}
+
 my %versions = C4::Context::get_versions();
 
 $template->param(
@@ -558,6 +601,8 @@ foreach my $pm_type(@pm_types) {
                 current => ($pm_type eq 'current_pm' ? 1 : 0),
                 require => $stats->{'required'},
                 reqversion => $stats->{'min_ver'},
+                maxversion => $stats->{'max_ver'},
+                excversion => $stats->{'exc_ver'}
             }
         );
     }