LP#1676608: don't sound the klaxon for unusual copy statuses during checkin
authorGalen Charlton <gmc@equinoxinitiative.org>
Tue, 27 Feb 2018 22:23:22 +0000 (17:23 -0500)
committerMike Rylander <mrylander@gmail.com>
Wed, 28 Feb 2018 15:26:44 +0000 (10:26 -0500)
During a successful checkin, play the success sound if an
unexpected copy status is noted in the success message -- it
may have been set via a copy alert.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Open-ILS/web/js/ui/default/staff/circ/services/circ.js

index f349f6c..f191884 100644 (file)
@@ -1493,8 +1493,8 @@ function($uibModal , $q , egCore , egAlertDialog , egConfirmDialog,  egAddCopyAl
                         return $q.when(final_resp);
 
                     default:
-                        egCore.audio.play('error.checkin.unknown');
-                        console.error('Unhandled checkin copy status: ' 
+                        egCore.audio.play('success.checkin');
+                        console.debug('Unusual checkin copy status (may have been set via copy alert): '
                             + copy.status().id() + ' : ' + copy.status().name());
                         return $q.when(final_resp);
                 }