LP1906858 Carousels Ignore Deleted Flag

Adds logic to look for the copy deleted flag in the carousel queries.

To test in concerto, it is easiest to create one item on three or four bibs
and assign the same org unit and location code to these items.

Check the items in. Check the items out, and then check them back in at their home OU.

Create 4 carousels.  Newly Catalogued Items, Recently Returned Items, Top Circulated Items, and Newest Items by Shelving Location.
Make sure the carousels pull from the item library for which the items belong,
and set the owner to CONS. Select and add the correct shelving location.

Refresh the carousels. In the edit dialog box of each carousel, you can click the Link to bucket link to see the titles in the bucket.

Delete one of the items.  Refresh the carousels once more and notice that the deleted title still appears.

Apply the patch.

Refresh the carousels, and the delete item should now be gone.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/container.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/container.pm
index 176197a..93ce1f7 100644 (file)
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/container.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/container.pm
@@ -18,6 +18,7 @@ my $new_items_query = q(
     AND acp.circ_lib IN (ORG_LIST)
     AND acp.holdable
     AND acp.circulate
+    AND acp.deleted is false
     AND ccs.holdable
     AND acpl.holdable
     AND acpl.circulate
@@ -42,6 +43,7 @@ WITH c_attr AS (SELECT c_attrs::query_int AS vis_test FROM asset.patron_default_
     AND acp.circ_lib IN (ORG_LIST)
     AND acp.holdable
     AND acp.circulate
+    AND acp.deleted is false
     AND ccs.holdable
     AND acpl.holdable
     AND acpl.circulate
@@ -67,6 +69,7 @@ my $top_circs_query = q(
     AND acp.circ_lib IN (ORG_LIST)
     AND acp.holdable
     AND acp.circulate
+    AND acp.deleted is false
     AND ccs.holdable
     AND acpl.holdable
     AND acpl.circulate
@@ -92,6 +95,7 @@ my $new_by_loc_query = q(
     -- LOC AND acp.location IN (LOC_LIST)
     AND acp.holdable
     AND acp.circulate
+    AND acp.deleted is false
     AND ccs.holdable
     AND acpl.holdable
     AND acpl.circulate