lp1646210 Call Number Affixes Waiting for Copy bugfix
authorKyle Huckins <khuckins@catalyte.io>
Thu, 16 Nov 2017 23:54:48 +0000 (23:54 +0000)
committerKathy Lussier <klussier@masslnc.org>
Fri, 17 Nov 2017 16:28:55 +0000 (11:28 -0500)
-Checks for a volume in hold data, preventing broken grids in cases
where a hold is waiting for copy

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>

 Changes to be committed:
modified:   Open-ILS/web/js/ui/default/staff/circ/services/holds.js

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Open-ILS/web/js/ui/default/staff/circ/services/holds.js

index 8b1d0f4..656e7c4 100644 (file)
@@ -489,14 +489,16 @@ function($uibModal , $q , egCore , egConfirmDialog , egAlertDialog) {
                     ).then(function(c) { hold.current_copy().status(c) });
         }
 
-        //Call number affixes are not always fleshed in the API
-        if (volume.prefix() && typeof volume.prefix() != 'object') {
-            console.debug('fetching call number prefix');
-            egCore.pcrud.retrieve('acnp',volume.prefix()).then(function(p) {volume.prefix(p)});
-        }
-        if (volume.suffix() && typeof volume.suffix() != 'object') {
-            console.debug('fetching call number prefix');
-            egCore.pcrud.retrieve('acns',volume.suffix()).then(function(s) {volume.suffix(s)});
+        if (volume) {
+            //Call number affixes are not always fleshed in the API
+            if (volume.prefix() && typeof volume.prefix() != 'object') {
+                console.debug('fetching call number prefix');
+                egCore.pcrud.retrieve('acnp',volume.prefix()).then(function(p) {volume.prefix(p)});
+            }
+            if (volume.suffix() && typeof volume.suffix() != 'object') {
+                console.debug('fetching call number prefix');
+                egCore.pcrud.retrieve('acns',volume.suffix()).then(function(s) {volume.suffix(s)});
+            }
         }
     }