LP#1685840: Dojoless Google Books Preview as external script

Rather than including the JavaScript inline in each page, load the
JavaScript as a regular external JavaScript file so that browsers
can take advantage of caching, reduce network bandwidth, and reduce the
amount of TT2 processing required. Every little bit helps.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

diff --git a/Open-ILS/src/templates/opac/parts/js.tt2 b/Open-ILS/src/templates/opac/parts/js.tt2
index 1deac91..f7fc737 100644 (file)
--- a/Open-ILS/src/templates/opac/parts/js.tt2
+++ b/Open-ILS/src/templates/opac/parts/js.tt2
@@ -59,7 +59,9 @@
     IF CGI.https; url = url.replace('^http:', 'https:'); END; %]
 <script type='text/javascript' id='EIT' src='[% url %]'></script>
 [%- END %]
-[% INCLUDE "opac/parts/ac_google_books.tt2" IF ctx.page == 'record' AND ctx.google_books_preview %]
+[%- IF ctx.page == 'record' AND ctx.google_books_preview %]
+<script src='[% ctx.media_prefix %]/js/ui/default/opac/ac_google_books.js' async defer></script>
+[%- END %]
 [%- IF want_dojo; -%]
 <script type="text/javascript">
      var djConfig = {

diff --git a/Open-ILS/src/templates/opac/parts/ac_google_books.tt2 b/Open-ILS/web/js/ui/default/opac/ac_google_books.js
similarity index 99%
rename from Open-ILS/src/templates/opac/parts/ac_google_books.tt2
rename to Open-ILS/web/js/ui/default/opac/ac_google_books.js
index 22f6963..6c9aa00 100644 (file)
--- a/Open-ILS/src/templates/opac/parts/ac_google_books.tt2
+++ b/Open-ILS/web/js/ui/default/opac/ac_google_books.js
@@ -1,4 +1,3 @@
-<script>
 ;(function () {
   var GBisbns = [];
   var GBPBadgelink;
@@ -161,4 +160,3 @@
     window.addEventListener('load', GBLoader, false);
   }
 })()
-</script>