LP#1745462: avoid trying to validate empty fields
authorGalen Charlton <gmc@equinoxinitiative.org>
Thu, 25 Jan 2018 19:57:40 +0000 (14:57 -0500)
committerChris Sharp <csharp@georgialibraries.org>
Wed, 11 Jul 2018 18:29:26 +0000 (14:29 -0400)
commiteb0c22425d41910be16b405a19bccf9f07b4a54b
tree6e35c6ea058b24b84c862fba4e4f661ffa96a8af
parent91cd25fbcab912aabfc0df204b46b5a67ab6d8b8
LP#1745462: avoid trying to validate empty fields

This patch is the belt to the previous patch's suspenders and ensures
that the web staff client does not attempt to authority-validate headings
fields in the MARC editor if they're empty (i.e., no subfield values).

To test
-------
[1] In the web staff client, create a new bib. Ensure that at least one of the
    authority-controlled fields has no subfield values.
[2] Hit the Validate button.
[3] Note that the field(s) with empty headings show the tick
    mark indicating that they've been "validated".
[4] Apply the patch and repeat steps 1 and 2. This time, empty headings
    field should not be checked.
[5] Verify that validating headings that are not empty does continue
    to work.

Patch inspired by Mike Rylander.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Open-ILS/web/js/ui/default/staff/cat/services/marcedit.js
Open-ILS/web/js/ui/default/staff/cat/services/tagtable.js