Lp 1861319: Repair expire setting logic
authorJason Stephenson <jason@sigio.com>
Mon, 25 Jan 2021 19:23:41 +0000 (14:23 -0500)
committerGalen Charlton <gmc@equinoxinitiative.org>
Wed, 10 Mar 2021 19:59:40 +0000 (14:59 -0500)
commit45d69d36d5853d70a029f249cc15cb89c523b343
tree1fda6966c15ab1f658f858c1b0dae068e1d8d429
parente5f46bb9920b039ec6de73e6d7dea2a1d2da5217
Lp 1861319: Repair expire setting logic

Move the checks in Circulate.pm from mk_env to do_renew after the
circ_lib has been set for opac, auto, and desk renewals.

Only check for expired patrons in mk_env if we're not doing a renewal,
i.e. it's a regular checkout.

OPINION: That checks for patron validity in mk_env should be moved to
their own subroutine and called from do_checkout and do_renew.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm