From 9e7e9c0836972128f8a090dfc9cbe787c63c1b00 Mon Sep 17 00:00:00 2001 From: Thomas Berezansky Date: Thu, 12 Jul 2012 11:42:21 -0400 Subject: [PATCH] Remove an extra ternary op And adjust the comment to make more sense. There is no higher level filter that prevents copy holds on parted items, so there is no filter for them to "slip through". Signed-off-by: Thomas Berezansky Signed-off-by: Ben Shum --- .../Application/Storage/Publisher/action.pm | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm index 640525c..4101309 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm @@ -1268,8 +1268,8 @@ sub new_hold_copy_targeter { isTrue($_->holdable) && !isTrue($_->deleted) && (isTrue($hold->mint_condition) ? isTrue($_->mint_condition) : 1) && - ( ($hold->hold_type ne 'C' && $hold->hold_type ne 'I') ? # Copy-ish holds can target if they slipped through - ($hold->hold_type ne 'P' ? $_->part_maps->count == 0 : 1) : 1 ) + ( ( $hold->hold_type ne 'C' && $hold->hold_type ne 'I' # Copy-level holds don't care about parts + && $hold->hold_type ne 'P' ) ? $_->part_maps->count == 0 : 1) } @$all_copies; } -- 1.7.2.5