From: Lebbeous Fogle-Weekley Date: Thu, 30 Aug 2012 16:20:13 +0000 (-0400) Subject: Acq: Fix General Search for Lineitem Attribute-based fields X-Git-Url: http://git.equinoxoli.org/?p=transitory.git;a=commitdiff_plain;h=6f9892fc38372d812fd2d8e3cd1be4523fd9e89b Acq: Fix General Search for Lineitem Attribute-based fields Reported by Ben Shum and Kathy Lussier, the Acq General Search interface was broken in that you couldn't use any of the search fields under Lineitem Attribute. This error was indeed introduced by recent commit 55a82b5 as Ben determined, but simply reverting that commit left other things broken. This commit actually targets the problem and seems to fix it in my testing. Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Bill Erickson --- diff --git a/Open-ILS/web/js/ui/default/acq/search/unified.js b/Open-ILS/web/js/ui/default/acq/search/unified.js index 6f6142f..c0a1fa9 100644 --- a/Open-ILS/web/js/ui/default/acq/search/unified.js +++ b/Open-ILS/web/js/ui/default/acq/search/unified.js @@ -129,7 +129,13 @@ function TermSelectorFactory(terms) { ) { var term = this.getTerm(); var widgetKey = this.uniq; - var target = termManager.getLinkTarget(term); + var target; + try { + target = termManager.getLinkTarget(term); + } catch (E) { + void(0); /* ok for this to fail (it doesn't handle acqlia right, + but we don't need it to in this case). */ + }; if (matchHow.getValue() == "__in") { new openils.widget.XULTermLoader({