From b94f4083eb18a99060c2b974b0196c561e103d7d Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Mon, 26 Nov 2018 13:08:05 +0000 Subject: [PATCH] Bug 21869: Fix incorrect value setting in DB update To test: 1 - Set some value for MarkLostAsReturned syspref 2 - Set your db version to 17.12.00.035 (or load an older db) 3 - updatedatabase 4 - Note your values are lost and db is incorrectly set 5 - Apply patch 6 - Reset values 7 - Reset DB version 8 - Run updatedatabase 9 - Original values are retained Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens Signed-off-by: Jesse Maseto --- installer/data/mysql/updatedatabase.pl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl index d477105..ec2bfa0 100755 --- a/installer/data/mysql/updatedatabase.pl +++ b/installer/data/mysql/updatedatabase.pl @@ -15924,7 +15924,7 @@ if( CheckVersion( $DBversion ) ) { INSERT IGNORE INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` ) VALUES ('UpdateItemWhenLostFromHoldList','',NULL,'This is a list of values to update an item when it is marked as lost from the holds to pull screen','Free'); } ); $dbh->do( q{ - UPDATE systempreferences SET options="batchmod|moredetail|cronjob|additem|pendingreserves", value="batchmod|moredetail|cronjob|additem|pendingreserves" WHERE variable="MarkLostItemsAsReturned"; + UPDATE systempreferences SET options="batchmod|moredetail|cronjob|additem|pendingreserves" WHERE variable="MarkLostItemsAsReturned"; } ); SetVersion( $DBversion ); -- 1.7.2.5