From b78bd2faec703bb7d7c750dbc1070ba2449f29a9 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Fri, 19 Apr 2019 06:49:48 +0000 Subject: [PATCH] Bug 22735: Resolve internal server error on missing item type Trivial fix, similar to opac-detail, applied to ISBD and MARC detail. Test plan: Enable ArticleRequests pref. Make sure you have a biblio with no item type in 942c. (Perhaps you need to make 942c not mandatory temporarily and save a biblio record without this field being filled.) If you are logged in, log out. Go to MARC or ISBD detail page. No crash anymore? Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens --- opac/opac-ISBDdetail.pl | 5 ++++- opac/opac-MARCdetail.pl | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/opac/opac-ISBDdetail.pl b/opac/opac-ISBDdetail.pl index ed39f72..50d08b3 100755 --- a/opac/opac-ISBDdetail.pl +++ b/opac/opac-ISBDdetail.pl @@ -226,9 +226,12 @@ if (my $search_for_title = C4::Context->preference('OPACSearchForTitleIn')){ } if( C4::Context->preference('ArticleRequests') ) { + my $itemtype = Koha::ItemTypes->find($biblio->itemtype); my $artreqpossible = $patron ? $biblio->can_article_request( $patron ) - : Koha::ItemTypes->find($biblio->itemtype)->may_article_request; + : $itemtype + ? $itemtype->may_article_request + : q{}; $template->param( artreqpossible => $artreqpossible ); } diff --git a/opac/opac-MARCdetail.pl b/opac/opac-MARCdetail.pl index 4867eda..dd70900 100755 --- a/opac/opac-MARCdetail.pl +++ b/opac/opac-MARCdetail.pl @@ -351,9 +351,12 @@ if (my $search_for_title = C4::Context->preference('OPACSearchForTitleIn')){ } if( C4::Context->preference('ArticleRequests') ) { + my $itemtype = Koha::ItemTypes->find($biblio->itemtype); my $artreqpossible = $patron ? $biblio->can_article_request( $patron ) - : Koha::ItemTypes->find($biblio->itemtype)->may_article_request; + : $itemtype + ? $itemtype->may_article_request + : q{}; $template->param( artreqpossible => $artreqpossible ); } -- 1.7.2.5