From 477347b93e755020a2f346306e039c5c92584344 Mon Sep 17 00:00:00 2001
From: helene hickey <hickeyhe@wgc.school.nz>
Date: Tue, 15 Jan 2019 03:47:58 +0000
Subject: [PATCH] Bug 22054: Updated the error message for attempting to renew an onsite checkout

To test:

1) Enable OnSiteCheckouts system preference
2) Checkout an item checking the onsite checkout checkbos in more
options
3) Go to circulation > pending on-site checkouts
4) Verify the checkout shows
5) Go to circulation > renew
6) Try to renew the on-site checkout using the barcode
7) Verify display:

onsite_checkout  Continue without renewing

8) apply the patch and reload page with error message
9) verify display:

Item cannot be renewed because it's an onsite checkout

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 4eab8308353948c81d9a05978584073354cb43e5)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 3dd7d9dfad0052761e4a3e7a93fce6e7d8055c93)

Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com>
(cherry picked from commit c0b2ad7da5a7ea79dbb79ad1b57c96a01431bb3a)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
---
 .../intranet-tmpl/prog/en/modules/circ/renew.tt    |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/renew.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/renew.tt
index bd4cfa2..79ab59a 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/renew.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/renew.tt
@@ -129,6 +129,9 @@
 
                                 <p>[% borrower.firstname %] [% borrower.surname %] ( <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrower.borrowernumber %]"> [% borrower.cardnumber %] </a> ) is currently restricted.</p>
 
+                            [% ELSIF error == "onsite_checkout" %]
+                                <p>Item cannot be renewed because it's an onsite checkout</p>
+
                             [% ELSE %]
 
                                 [% error %]
-- 
1.7.2.5