From: Arthur Suzuki <arthur.suzuki@biblibre.com>
Date: Tue, 25 Jun 2019 09:17:24 +0000 (+0200)
Subject: Bug 23199: Koha::Patron->store must check 'uppercasesurname' syspref
X-Git-Tag: v19.11.00~1113
X-Git-Url: http://git.equinoxoli.org/?p=koha.git;a=commitdiff_plain;h=fa390ca232a0979c6786a0e00eca8d458f644f3e

Bug 23199: Koha::Patron->store must check 'uppercasesurname' syspref

Test plan:
1/ set uppercasesurname to 'Do'
2/ register a new patron using the REST API with lowercase surname
3/ verify the surname is not saved in uppercase
4/ apply patch
5/ repeat 2
6/ verify the surname now is saved to uppercase

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
---

diff --git a/Koha/Patron.pm b/Koha/Patron.pm
index b1d9b14..bde22cd 100644
--- a/Koha/Patron.pm
+++ b/Koha/Patron.pm
@@ -193,6 +193,10 @@ sub store {
 
             $self->trim_whitespaces;
 
+            # Set surname to uppercase if uppercasesurname is true
+        $self->surname( uc($self->surname) )
+        if C4::Context->preference("uppercasesurname");
+
             unless ( $self->in_storage ) {    #AddMember
 
                 # Generate a valid userid/login if needed
diff --git a/members/memberentry.pl b/members/memberentry.pl
index bd86e36..18f3a96 100755
--- a/members/memberentry.pl
+++ b/members/memberentry.pl
@@ -343,10 +343,6 @@ if ($op eq 'save' || $op eq 'insert'){
         }
     }
   
-    if($newdata{surname} && C4::Context->preference('uppercasesurnames')) {
-        $newdata{'surname'} = uc($newdata{'surname'});
-    }
-
   if (C4::Context->preference("IndependentBranches")) {
     unless ( C4::Context->IsSuperLibrarian() ){
       $debug and print STDERR "  $newdata{'branchcode'} : ".$userenv->{flags}.":".$userenv->{branch};