From: Fridolin Somers <fridolin.somers@biblibre.com>
Date: Mon, 19 Nov 2018 14:45:49 +0000 (+0100)
Subject: Bug 21865: add confirm to remove_unused_authorities.pl script
X-Git-Tag: v20.05.00~575
X-Git-Url: http://git.equinoxoli.org/?p=koha.git;a=commitdiff_plain;h=e788ac4e5838ad530424eeff24302f5aee4c452a

Bug 21865: add confirm to remove_unused_authorities.pl script

Like in most scripts in misc, add confirm argument
to ensure script is not run without knowing what it does.

Test plan:
1) Run misc/migration_tools/remove_unused_authorities.pl -h
2) You see help line for confirm
3) Run misc/migration_tools/remove_unused_authorities.pl
4) You see help and script does nothing
5) Run misc/migration_tools/remove_unused_authorities.pl -c
6) Script runs like wanted

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
---

diff --git a/misc/migration_tools/remove_unused_authorities.pl b/misc/migration_tools/remove_unused_authorities.pl
index 30acf5d..00869a9 100755
--- a/misc/migration_tools/remove_unused_authorities.pl
+++ b/misc/migration_tools/remove_unused_authorities.pl
@@ -30,15 +30,15 @@ use Getopt::Long;
 use Koha::SearchEngine::Search;
 
 my @authtypes;
-my $want_help = 0;
-my $test = 0;
+my ($confirm, $test, $want_help);
 GetOptions(
     'aut|authtypecode:s' => \@authtypes,
+    'c|confirm'          => \$confirm,
     't|test'             => \$test,
-    'h|help'             => \$want_help
+    'h|help'             => \$want_help,
 );
 
-if ($want_help) {
+if ( $want_help || !$confirm ) {
     print_usage();
     exit 0;
 }
@@ -129,11 +129,14 @@ particular type will be checked for usage.  --aut can be repeated.
 
 If --aut is not supplied, all authority records will be checked.
 
+Use --confirm Confirms you want to really run this script, otherwise prints this help.
+
 Use --test to perform a test run.  This script does not ask the
 operator to confirm the deletion of each authority record.
 
 parameters
     --aut|authtypecode TYPE       the list of authtypes to check
+    --confirm or -c               confirm running of script
     --test or -t                  test mode, don't delete really, just count
     --help or -h                  show this message.