From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Thu, 13 Aug 2020 16:42:56 +0000 (+0200)
Subject: Bug 18501: but.. what was the meaning of holdingbranch here?
X-Git-Url: http://git.equinoxoli.org/?p=koha.git;a=commitdiff_plain;h=9d807113dc082255ded81279544b53ee3e15168e

Bug 18501: but.. what was the meaning of holdingbranch here?

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
---

diff --git a/C4/Circulation.pm b/C4/Circulation.pm
index bb235b9..dfdbb1a 100644
--- a/C4/Circulation.pm
+++ b/C4/Circulation.pm
@@ -2008,7 +2008,6 @@ sub AddReturn {
 
     # the holdingbranch is updated if the document is returned to another location.
     # this is always done regardless of whether the item was on loan or not
-    my $item_holding_branch = $item->holdingbranch;
     if ($item->holdingbranch ne $branch) {
         $item->holdingbranch($branch)->store;
     }
@@ -2040,12 +2039,6 @@ sub AddReturn {
     if ( $item->itemlost ) {
         $messages->{'WasLost'} = 1;
         unless ( C4::Context->preference("BlockReturnOfLostItems") ) {
-            my $refunded = $item->set_found(
-                {
-                    holdingbranch  => $item_holding_branch,
-                }
-            );
-
             $messages->{'LostItemFeeRefunded'} = $refunded;
         }
     }