From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Tue, 25 Jun 2019 22:43:41 +0000 (-0500)
Subject: Bug 23211: Prevent SIP/Transaction.t to fail randomly
X-Git-Tag: v19.11.00~1183
X-Git-Url: http://git.equinoxoli.org/?p=koha.git;a=commitdiff_plain;h=466f99e44230968aeb51598e50f65d212941c5b4

Bug 23211: Prevent SIP/Transaction.t to fail randomly

The checkout failed because patron's category is the one used for statistics (category_type=X).

To recreate the failure:
modified: t/db_dependent/SIP/Transaction.t
@ Transaction.t:37 @ subtest fill_holds_at_checkout => sub {
     plan tests => 6;

-    my $category = $builder->build({ source => 'Category' });
+    my $category = $builder->build({ source => 'Category', value => { category_type => 'X' }});
     my $branch   = $builder->build({ source => 'Branch' });
     my $borrower = $builder->build({ source => 'Borrower', value =>{
         branchcode => $branch->{branchcode},

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
---

diff --git a/t/db_dependent/SIP/Transaction.t b/t/db_dependent/SIP/Transaction.t
index 0e78505..076fb29 100755
--- a/t/db_dependent/SIP/Transaction.t
+++ b/t/db_dependent/SIP/Transaction.t
@@ -34,7 +34,7 @@ subtest fill_holds_at_checkout => sub {
     plan tests => 6;
 
 
-    my $category = $builder->build({ source => 'Category' });
+    my $category = $builder->build({ source => 'Category', value => { category_type => 'A' }});
     my $branch   = $builder->build({ source => 'Branch' });
     my $borrower = $builder->build({ source => 'Borrower', value =>{
         branchcode => $branch->{branchcode},