From: Julian Maurice <julian.maurice@biblibre.com>
Date: Mon, 25 Jun 2018 12:58:17 +0000 (+0200)
Subject: Bug 16653: (QA follow-up) Avoid a warning and remove unused variables
X-Git-Tag: v18.11.00~1438
X-Git-Url: http://git.equinoxoli.org/?p=koha.git;a=commitdiff_plain;h=1a01c62f9dfca77df084501baa546afaa39dbe0f

Bug 16653: (QA follow-up) Avoid a warning and remove unused variables

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
---

diff --git a/reports/cat_issues_top.pl b/reports/cat_issues_top.pl
index c7a974b..604258e 100755
--- a/reports/cat_issues_top.pl
+++ b/reports/cat_issues_top.pl
@@ -93,7 +93,7 @@ if ($do_it) {
             print $line->{rowtitle}.$sep;
             foreach my $cell (@$x) {
                 print $cell->{value}.$sep;
-                print $cell->{count};
+                print $cell->{count} // '';
             }
             print "\n";
         }
@@ -102,10 +102,6 @@ if ($do_it) {
 # Displaying choices
 } else {
     my $dbh = C4::Context->dbh;
-    my @values;
-    my %labels;
-    my %select;
-    my $req;
     
     my $CGIextChoice = ( 'CSV' ); # FIXME translation
     my $CGIsepChoice=GetDelimiterChoices;
@@ -157,7 +153,6 @@ sub calculate {
     my ($line, $column, $filters) = @_;
     my @mainloop;
     my @loopcol;
-    my @loopline;
     my @looprow;
     my %globalline;
     my $grantotal =0;
@@ -357,7 +352,6 @@ sub calculate {
     
     my $dbcalc = $dbh->prepare($strcalc);
     $dbcalc->execute;
-    my $previous_col;
     my %indice;
     while (my  @data = $dbcalc->fetchrow) {
         my ($row, $rank, $id, $callnum, $ccode, $loc, $col )=@data;