Bug 21460: (follow-up) Fix bugs found in QA

Fix silly bugs mentioned in comment #29

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

diff --git a/Koha/REST/V1/Illrequests.pm b/Koha/REST/V1/Illrequests.pm
index f747390..907dc5c 100644 (file)
--- a/Koha/REST/V1/Illrequests.pm
+++ b/Koha/REST/V1/Illrequests.pm
@@ -57,7 +57,7 @@ sub list {
     # Get all requests
     # If necessary, only get those from a specified patron
     my @requests = Koha::Illrequests->search({
-        args->{borrowernumber}
+        $args->{borrowernumber}
         ? ( borrowernumber => $args->{borrowernumber} )
         : ()
     })->as_list;

diff --git a/ill/ill-requests.pl b/ill/ill-requests.pl
index 57b0692..010c61e 100755 (executable)
--- a/ill/ill-requests.pl
+++ b/ill/ill-requests.pl
@@ -280,8 +280,8 @@ if ( $backends_available ) {
                     uri_escape_utf8(scalar $params->{$filter});
             }
         }
+        my @tpl_arr = ();
         if (keys %{$active_filters}) {
-            my @tpl_arr;
             foreach my $key (keys %{$active_filters}) {
                 push @tpl_arr, $key . "=" . $active_filters->{$key};
             }

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
index 8feeccb..88ee777 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
@@ -527,7 +527,7 @@
     [% INCLUDE 'calendar.inc' %]
     [% Asset.js("lib/jquery/plugins/jquery.checkboxes.min.js") | $raw %]
     <script>
-        var prefilters = '[% prefilters %]';
+        var prefilters = '[% prefilters | $raw %]';
         // Set column settings
         var columns_settings = [% ColumnsSettings.GetColumns( 'illrequests', 'ill-requests', 'ill-requests', 'json' ) %];
     </script>