From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Date: Mon, 24 Aug 2020 08:03:48 +0000 (+0000)
Subject: Bug 26265: (QA follow-up) Remove g option from regex, add few dirs
X-Git-Url: http://git.equinoxoli.org/?p=koha-equinox.git;a=commitdiff_plain;h=HEAD

Bug 26265: (QA follow-up) Remove g option from regex, add few dirs

Adding .git. Using a regex.
If we make it a bit smarter, we do not need most dirs listed.

Test plan:
Run the test again

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
---

diff --git a/xt/check_makefile.t b/xt/check_makefile.t
index 23a8bf3..458f195 100755
--- a/xt/check_makefile.t
+++ b/xt/check_makefile.t
@@ -30,12 +30,8 @@ my $makefile = read_file("$curdir/Makefile.PL");
 my @missing;
 for my $d ( sort @dirs ) {
     chomp $d;
-    next if $d eq './Koha';
-    next if $d eq './C4';
-    next if $d eq './koha-tmpl';
-    next if $d eq './etc';
-    next if $d eq './debian';
-    next if $makefile =~ m|'$d'|gxms;
+    next if $d =~ /\.\/(debian|\.git)$/;
+    next if $makefile =~ m{'$d('|\/)}xms;
     push @missing, $d;
 }