From: Katrin Fischer <katrin.fischer.83@web.de>
Date: Tue, 9 Apr 2019 23:15:30 +0000 (+0200)
Subject: Bug 22580: Remove deprecated delete_expired_opac_registrations.pl cronjob
X-Git-Url: http://git.equinoxoli.org/?p=koha-equinox.git;a=commitdiff_plain;h=9ebdfb1ed1ff1c7a110dc7a7718bb17cd231f66f

Bug 22580: Remove deprecated delete_expired_opac_registrations.pl cronjob

Removes the deprecated script and changes the hint on the
PatronSelfRegistrationExpireTemporaryAccountsDelay sytem preference.

To test:
- Make sure the script misc/cronjobs/delete_expired_opac_registrations.pl
  was deleted
- Make sure the hint on the PatronSelfRegistrationExpireTemporaryAccountsDelay
  system preference is correct
- Make sure there are no other reference to the removed script

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
---

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
index 8d9b396..3112807 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
@@ -765,7 +765,7 @@ OPAC:
             - pref: PatronSelfRegistrationExpireTemporaryAccountsDelay
               class: integer
             - "days."
-            - "<br><strong>NOTE:</strong> This system preference requires the <code>misc/cronjobs/delete_expired_opac_registrations.pl</code> cronjob. Ask your system administrator to schedule it."
+            - "<br><strong>NOTE:</strong> This system preference requires the <code>misc/cronjobs/cleanup_database.pl</code> cronjob. Ask your system administrator to schedule it."
         -
             - "The following <a href='http://schema.koha-community.org/__VERSION__/tables/borrowers.html' target='blank'>database columns</a> must be filled in on the patron entry screen:"
             - pref: PatronSelfRegistrationBorrowerMandatoryField
diff --git a/misc/cronjobs/delete_expired_opac_registrations.pl b/misc/cronjobs/delete_expired_opac_registrations.pl
deleted file mode 100755
index 28dd3c7..0000000
--- a/misc/cronjobs/delete_expired_opac_registrations.pl
+++ /dev/null
@@ -1,71 +0,0 @@
-#!/usr/bin/perl
-
-# Copyright 2009-2010 Kyle Hall
-#
-# This file is part of Koha.
-#
-# Koha is free software; you can redistribute it and/or modify it
-# under the terms of the GNU General Public License as published by
-# the Free Software Foundation; either version 3 of the License, or
-# (at your option) any later version.
-#
-# Koha is distributed in the hope that it will be useful, but
-# WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with Koha; if not, see <http://www.gnu.org/licenses>.
-
-use Modern::Perl;
-use Getopt::Long;
-
-BEGIN {
-
-    # find Koha's Perl modules
-    # test carefully before changing this
-    use FindBin;
-    eval { my $lib = "$FindBin::Bin/../kohalib.pl"; require $lib };
-}
-
-use Koha::Script -cron;
-use C4::Context;
-
-my $help;
-my $confirm;
-my $verbose;
-
-GetOptions(
-    'h|help'    => \$help,
-    'c|confirm' => \$confirm,
-    'v|verbose' => \$verbose,
-);
-my $usage = << 'ENDUSAGE';
-
-IMPORTANT: You should no longer call this script. Please use
-cleanup_database.pl with parameter --del-exp-selfreg.
-
-This script removes confirmed OPAC based patron registrations
-that have not been changed from the patron category specified
-in the system preference PatronSelfRegistrationDefaultCategory
-within the required time period.
-
-NOTE: If you do not use self registration, do NOT run this script.
-If you use self registration, but you do not use a temporary
-category for new registrations, do NOT run this script too.
-
-This script has the following parameters :
-    -c --confirm: Without this flag set, this script will do nothing.
-    -h --help:    Print this message.
-    -v --verbose: Print number of removed patrons.
-
-ENDUSAGE
-
-if ( $help || !$confirm ) {
-    print $usage;
-    exit;
-}
-
-my $c= "$FindBin::Bin/cleanup_database.pl --del-exp-selfreg";
-$c.= " -v" if $verbose;
-system($c);