From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Date: Thu, 20 Aug 2020 13:02:35 +0000 (+0100)
Subject: Bug 18501: (follow-up) Add fallback to ItemHomeBranch
X-Git-Url: http://git.equinoxoli.org/?p=koha-equinox.git;a=commitdiff_plain;h=7fe66325f0aa54aa3084941f8ed79af304b4acc3

Bug 18501: (follow-up) Add fallback to ItemHomeBranch

When 'RefundLostOnReturnControl' is set to 'CheckinLibrary' but
return_branch is passed as undefined we should fallback to
'ItemHomeBranch' before falling back to the default rule.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
---

diff --git a/t/db_dependent/Koha/CirculationRules.t b/t/db_dependent/Koha/CirculationRules.t
index 1473c23..9e3fb44 100644
--- a/t/db_dependent/Koha/CirculationRules.t
+++ b/t/db_dependent/Koha/CirculationRules.t
@@ -379,7 +379,7 @@ subtest 'get_effective_daysmode' => sub {
 };
 
 subtest 'get_lostreturn_policy() tests' => sub {
-    plan tests => 6;
+    plan tests => 7;
 
     $schema->storage->txn_begin;
 
@@ -451,8 +451,8 @@ subtest 'get_lostreturn_policy() tests' => sub {
 
     my $item = $builder->build_sample_item(
         {
-            homebranch    => $specific_rule_true->{branchcode},
-            holdingbranch => $specific_rule_false->{branchcode}
+            homebranch    => $specific_rule_false->{branchcode},
+            holdingbranch => $specific_rule_true->{branchcode}
         }
     );
     my $params = {
@@ -467,11 +467,11 @@ subtest 'get_lostreturn_policy() tests' => sub {
 
     t::lib::Mocks::mock_preference( 'RefundLostOnReturnControl', 'ItemHomeBranch' );
     is( Koha::CirculationRules->get_lostreturn_policy( $params ),
-         1,'Specific rule for home branch is applied (true)');
+         0,'Specific rule for home branch is applied (false)');
 
     t::lib::Mocks::mock_preference( 'RefundLostOnReturnControl', 'ItemHoldingBranch' );
     is( Koha::CirculationRules->get_lostreturn_policy( $params ),
-         0,'Specific rule for holoding branch is applied (false)');
+         1,'Specific rule for holding branch is applied (true)');
 
     # Default rule check
     t::lib::Mocks::mock_preference( 'RefundLostOnReturnControl', 'CheckinLibrary' );
@@ -499,5 +499,10 @@ subtest 'get_lostreturn_policy() tests' => sub {
     is( Koha::CirculationRules->get_lostreturn_policy( $params ),
          1,'No rule for branch, no default rule, fallback default (true)');
 
+    # Fallback to ItemHoldBranch if CheckinLibrary is undefined
+    $params->{return_branch} = undef;
+    is( Koha::CirculationRules->get_lostreturn_policy( $params ),
+         0,'return_branch undefined, fallback to ItemHomeBranch rule (false)');
+
     $schema->storage->txn_rollback;
 };