From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Date: Tue, 21 Jul 2020 10:18:16 +0000 (+0100)
Subject: Bug 8338: (QA follow-up) Fix test for backdated return
X-Git-Url: http://git.equinoxoli.org/?p=koha-equinox.git;a=commitdiff_plain;h=56ee42082f0382d2b5e5a8cef081bef886664d7d

Bug 8338: (QA follow-up) Fix test for backdated return

A test for CalculateFinesOnBackdate was introduced since this bug was
written and needed updateing.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
---

diff --git a/t/db_dependent/Circulation/Returns.t b/t/db_dependent/Circulation/Returns.t
index 864f47d..5f3576a 100644
--- a/t/db_dependent/Circulation/Returns.t
+++ b/t/db_dependent/Circulation/Returns.t
@@ -400,7 +400,7 @@ subtest 'BranchTransferLimitsType' => sub {
 };
 
 subtest 'Backdated returns should reduce fine if needed' => sub {
-    plan tests => 1;
+    plan tests => 3;
 
     t::lib::Mocks::mock_preference( "CalculateFinesOnReturn",   0 );
     t::lib::Mocks::mock_preference( "CalculateFinesOnBackdate", 1 );
@@ -434,10 +434,14 @@ subtest 'Backdated returns should reduce fine if needed' => sub {
         branchcode => $patron->branchcode,
     })->store();
 
+    my $account = $patron->account;
+    is( $account->balance+0, 100, "Account balance before return is 100");
+
     my ( $doreturn, $messages, $issue ) = AddReturn($item->barcode, undef, undef, dt_from_string('1999-01-01') );
+    is( $account->balance+0, 0, "Account balance after return is 0");
 
-    $fine->discard_changes;
-    is( $fine->amountoutstanding+0, 0, "Fine was reduced correctly with a backdated return" );
+    $fine = $fine->get_from_storage;
+    is( $fine, undef, "Fine was removed correctly with a backdated return" );
 };
 
 $schema->storage->txn_rollback;