Bug 10300: (follow-up) add controls on transfers page
authorFridolin Somers <fridolin.somers@biblibre.com>
Thu, 28 Feb 2019 15:23:22 +0000 (16:23 +0100)
committerNick Clemens <nick@bywatersolutions.com>
Fri, 26 Apr 2019 11:49:08 +0000 (11:49 +0000)
commit80be039d6c6ccff18ac029b4e2081728aeba5748
tree07f6bc88e2d3576150740320afee68fafdef5f29
parent6e6a6230a5e59ec1866a12174233471a07d616b8
Bug 10300: (follow-up) add controls on transfers page

This patch moves the check of IndependentBranchesTransfers pref to templates and adds permission test inside branchtransfers.pl.
It also corrects the libraries combobox in branchtransfers.tt, this list can contain all libraries, it is the access to the page that may be protected.

Additions to test plan :
1)
1.1) Enable CircSidebar
1.2) In circulation home page check the effect of IndependentBranchesTransfers on "Transfer" link
1.3) Go to return page and check then effect of IndependentBranchesTransfers on "Transfer" link

2)
2.1) In circ/branchtransfers.pl, with and without IndependentBranches you see all libraries are in combobox

3)
3.1) Set IndependentBranchesTransfers to no and go to circ/branchtransfers.pl
3.2) You are redirected to page 403 unless you are superlibarian

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
circ/branchtransfers.pl
koha-tmpl/intranet-tmpl/prog/en/includes/circ-nav.inc
koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt
koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt