Bug 15253: Add Koha::Logger based logging for SIP2
authorKyle M Hall <kyle@bywatersolutions.com>
Tue, 1 May 2018 11:47:12 +0000 (11:47 +0000)
committerNick Clemens <nick@bywatersolutions.com>
Thu, 18 Apr 2019 11:37:27 +0000 (11:37 +0000)
commit03c03ed8cdb94cda4cfd661e3b04f97cb36d8dc4
tree11542968f24a18e8c0b8636f323a33d3cb3210b3
parent0bb1e01a0c553c18953be9799329128700e2d42b
Bug 15253: Add Koha::Logger based logging for SIP2

Now that we have Koha::Logger, we should use it in our SIP server. This
has the potential to make debugging SIP issue much easier. We should add
the userid for the sipuser to the namespace so we can allow for separate
files per sip user if wanted.

Also modifies the log4perl.conf to lazy-open filehandles to log files,
so the same config can be used with log-files needing different
permissions.

Test Plan:
1) Apply this patch set
2) Update the modififed log4perl.conf to your system
3) Restart your sip server
4) Tail your sip2.log, run some queries
5) Note you still get the same output messages as before, with the
   addition of the ip address and username ( if available )
   prefixing the message.

Based on original patches by Kyle Hall and additions by Olli-Antti
Kivilahti.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
12 files changed:
C4/SIP/ILS.pm
C4/SIP/ILS/Item.pm
C4/SIP/ILS/Patron.pm
C4/SIP/ILS/Transaction/Checkout.pm
C4/SIP/ILS/Transaction/RenewAll.pm
C4/SIP/SIPServer.pm
C4/SIP/Sip.pm
C4/SIP/Sip/Configuration.pm
C4/SIP/Sip/MsgType.pm
C4/SIP/Trapper.pm [new file with mode: 0644]
Koha/Logger.pm
etc/log4perl.conf